[PATCH] D78907: [RISCV] Add tests for checking isnan patterns

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

In D78907#2012362 <https://reviews.llvm.org/D78907#2012362>, @lenary wrote:

> In D78907#2012344 <https://reviews.llvm.org/D78907#2012344>, @asb wrote:
>
> > LGTM. Minor nit: using %0 and %2 as the only two named values seems odd though? Most other tests in test/CodeGen/RISCV use a/b/... for arguments and %0/%1/%2/... in the body.
>
>
> I generated the testcases in Clang (actually using godbolt, but it's doing the same IR lowering as clang HEAD is), which is why the arguments don't have names. I can re-introduce them if that's easier.


It's not the biggest deal in the world, but the following would better match conventions elsewhere in the dir (whether those conventions are sensible or not is another discussion of course!):

  define zeroext i1 @float_not_nan(float %a) nounwind {
    %1 = fcmp ord float %a, 0.000000e+00
    ret i1 %1
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78907/new/

https://reviews.llvm.org/D78907