[PATCH] D78907: [RISCV] Add tests for checking isnan patterns

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 03:57:45 PDT 2020


lenary added a comment.

In D78907#2012344 <https://reviews.llvm.org/D78907#2012344>, @asb wrote:

> LGTM. Minor nit: using %0 and %2 as the only two named values seems odd though? Most other tests in test/CodeGen/RISCV use a/b/... for arguments and %0/%1/%2/... in the body.


I generated the testcases in Clang (actually using godbolt, but it's doing the same IR lowering as clang HEAD is), which is why the arguments don't have names. I can re-introduce them if that's easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78907/new/

https://reviews.llvm.org/D78907





More information about the llvm-commits mailing list