[PATCH] D79058: [MachineVerifier] Add a pass to ensure debug locations within a basic block are monotonically increasing

[Vedant Kumar via Phabricator via llvm-commits]

vsk requested changes to this revision.
vsk added a comment.
This revision now requires changes to proceed.

I don’t think this should be part of MachineVerifier. The condition you’re checking for doesn’t indicate that the MIR is invalid. Even at -O0, you’ll hit it for code like:

int foo =

  Call();

Where we (currently, at least) step to “Call()” before we step to the assignment. I doubt this is the only such edge case.

I do still think the condition would be useful to check, perhaps in a separate ‘checking’ pass for debug info.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79058/new/

https://reviews.llvm.org/D79058