[PATCH] D79058: [MachineVerifier] Add a pass to ensure debug locations within a basic block are monotonically increasing
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 18:54:59 PDT 2020
paquette added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:337-340
+ // Debug instructions don't generate code, so we
+ // can skip them for verification's sake.
+ if (MI.isDebugInstr())
+ continue;
----------------
Would it make sense to use `MI.isMetaInstruction()` here instead? That should skip any instruction which does not generate code (including debug instructions.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79058/new/
https://reviews.llvm.org/D79058
More information about the llvm-commits
mailing list