[PATCH] D79078: [VectorCombine] Leave reduction operation to SLP

Wed Apr 29 05:19:55 PDT 2020

junparser added a comment.

In D79078#2009814 <https://reviews.llvm.org/D79078#2009814>, @lebedev.ri wrote:

> This needs a phase-ordering test.

For now vector-combine is executed before slp in both legacy pm and new pm with O2 <https://reviews.llvm.org/owners/package/2/>, so either we handle it here or slp can handle this kind of pattern.

> Why shouldn't SLPVectorizer be taught about that pattern instead?

I think we can handle this in SLP, however it may much hard than doing here? I'm not sure.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79078/new/

https://reviews.llvm.org/D79078