[PATCH] D79068: [MemorySSA] Pass DT to the upward iterator for proper PhiTranslation.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

oof. thanks for this!

lgtm once a few nits are addressed.



================
Comment at: llvm/include/llvm/Analysis/MemorySSA.h:726
 
+  auto &getDT() const { return *DT; }
+
----------------
nit: unless style around `auto` has changed, please spell out `const DominatorTree &`

(dunno offhand if `const` is possible here necessary, but ...)

secondary nit: since MSSA is a pretty big class with a fair few users, can we call this `getDomTree()` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79068/new/

https://reviews.llvm.org/D79068