[PATCH] D79068: [MemorySSA] Pass DT to the upward iterator for proper PhiTranslation.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 23:57:37 PDT 2020


asbirlea created this revision.
asbirlea added a reviewer: george.burgess.iv.
Herald added subscribers: hiraditya, Prazek.
Herald added a project: LLVM.

A valid DominatorTree is needed to do PhiTranslation.
Before this patch, a MemoryUse could be optimized to an access outside a loop, while the address it loads from is modified in the loop.
This can lead to a miscompile.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79068

Files:
  llvm/include/llvm/Analysis/MemorySSA.h
  llvm/lib/Analysis/MemorySSA.cpp
  llvm/test/Analysis/MemorySSA/phi-translation.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79068.260846.patch
Type: text/x-patch
Size: 5855 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200429/42703a54/attachment.bin>


More information about the llvm-commits mailing list