[PATCH] D70972: [AIX] Make sure we use export lists for plugins

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 19:27:22 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/CMakeLists.txt:838
+
+  # CMake versions less than 3.16 set default linker flags to include -brtl, as
+  # well as setting -G when building libraries, so clear them out.
----------------
hubert.reinterpretcast wrote:
> Do we risk variance in the configuration here if we leave the CMake default `-brtl` in `CMAKE_EXE_LINKER_FLAGS` when the version is less than 3.16? If we want that `-brtl`, then I'm also not sure I understand where we are adding it for CMake >= 3.16.
I see that we're adding `-brtl` somewhere else now; however, I'm still under the impression that not removing `-brtl` here from `CMAKE_EXE_LINKER_FLAGS` would cause variance on something that—according to the comment here—is known to be dependent on the CMake version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70972/new/

https://reviews.llvm.org/D70972





More information about the llvm-commits mailing list