[PATCH] D70972: [AIX] Make sure we use export lists for plugins

Mon Apr 27 09:39:23 PDT 2020

hubert.reinterpretcast added inline comments.

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:930
+# explicitly link against (exactly one) tool so we can't unilaterally turn on
 # LLVM_ENABLE_PLUGINS when it's enabled.
+set(LLVM_EXPORT_SYMBOLS_FOR_PLUGINS_AIX_default OFF)
----------------
Comment block is in the wrong location now. Leave a comment here about the AIX default, perhaps with a forward reference like "(see below)".

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:936
+
+CMAKE_DEPENDENT_OPTION(LLVM_EXPORT_SYMBOLS_FOR_PLUGINS
+       "Export symbols from LLVM tools so that plugins can import them" OFF
----------------
The large comment block goes here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70972/new/

https://reviews.llvm.org/D70972