[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

Sam McCall via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 15:57:36 PDT 2020


On Wed, Apr 29, 2020 at 12:52 AM Eric Christopher <echristo at gmail.com>
wrote:

> I've had to temporarily revert this as it was breaking some tests:
>
>     .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error:
> use of undeclared identifier 'set'
>         set(Value);
>         ^
>     1 error generated.
>
> Happy to help diagnose this with you if you need some assistance.
>
Doh, thanks for the revert.
I made one last change... and ran the wrong tests :-(
Relanded as 4e769e93b90b4d83ee795cda51bea9f76ca5ad5b


>
> Thanks!
>
> -eric
>
> On Tue, Apr 28, 2020 at 3:07 PM Vojtěch Štěpančík via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
>> VojtechStep added a comment.
>>
>> Great, thanks for the fixes!
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D78501/new/
>>
>> https://reviews.llvm.org/D78501
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200429/577308aa/attachment.html>


More information about the llvm-commits mailing list