<div dir="ltr"><div dir="ltr">On Wed, Apr 29, 2020 at 12:52 AM Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I've had to temporarily revert this as it was breaking some tests:<div><br></div><div>    .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: use of undeclared identifier 'set'<br>        set(Value);<br>        ^<br>    1 error generated.<br></div><div><br></div><div>Happy to help diagnose this with you if you need some assistance.</div></div></blockquote><div>Doh, thanks for the revert.</div><div>I made one last change... and ran the wrong tests :-(</div><div>Relanded as 4e769e93b90b4d83ee795cda51bea9f76ca5ad5b<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>Thanks!</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 28, 2020 at 3:07 PM Vojtěch Štěpančík via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">VojtechStep added a comment.<br>
<br>
Great, thanks for the fixes!<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D78501/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D78501/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D78501" rel="noreferrer" target="_blank">https://reviews.llvm.org/D78501</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div></div>