[PATCH] D79021: [mlir][rocdl] refactor ROCDL dialect.

[Wen-Heng (Jack) Chung via Phabricator via llvm-commits]

whchung marked an inline comment as done.
whchung added inline comments.


================
Comment at: mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h:27
+  LogicalResult
+  matchAndRewrite(Operation *op, ArrayRef<Value> operands,
+                  ConversionPatternRewriter &rewriter) const override {
----------------
rriddle wrote:
> Can you break this function up? It is fairly large.
This file is the identical copy from `mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp` , with only 2 places changed:

1) 
```
struct GPUFuncOpLowering : ConvertToLLVMPattern {
  explicit GPUFuncOpLowering(LLVMTypeConverter &typeConverter)
```

becomes

```
template <unsigned AllocaAddrSpace>
struct GPUFuncOpLowering : ConvertToLLVMPattern {
  explicit GPUFuncOpLowering(LLVMTypeConverter &typeConverter)
```

2)

```
        auto ptrType = typeConverter.convertType(type.getElementType())
                           .cast<LLVM::LLVMType>()
                           .getPointerTo();
```

becomes

```
        auto ptrType = typeConverter.convertType(type.getElementType())
                           .cast<LLVM::LLVMType>()
                           .getPointerTo(AllocaAddrSpace);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79021/new/

https://reviews.llvm.org/D79021