[PATCH] D79021: [mlir][rocdl] refactor ROCDL dialect.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 10:44:42 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h:27
+  LogicalResult
+  matchAndRewrite(Operation *op, ArrayRef<Value> operands,
+                  ConversionPatternRewriter &rewriter) const override {
----------------
Can you break this function up? It is fairly large.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79021/new/

https://reviews.llvm.org/D79021





More information about the llvm-commits mailing list