[PATCH] D78500: [DWARF5]:Added support for .debug_macro.dwo section in llvm-dwarfdump

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/include/llvm/MC/MCObjectFileInfo.h:116
   MCSection *DwarfMacinfoDWOSection = nullptr;
+  MCSection *DwarfMacroDWOSection = nullptr;
 
----------------
SouraVX wrote:
> ikudrin wrote:
> > It looks like the changes in `MC` files should not be in this patch.
> It is needed in MCObjectFileInfo.cpp.
> ```
>  DwarfMacroDWOSection =
>       Ctx->getELFSection(".debug_macro.dwo", DebugSecType, ELF::SHF_EXCLUDE);
> 
> ```
> 
Yes, but the changes in `MCObjectFileInfo.cpp` are also not needed for this patch.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-dwo.s:34-35
+	.long   .Lcu_str_off_end0-.Lcu_str_off_start0
+	.short	5
+	.short	0
+	.section	.debug_str.dwo,"eMS", at progbits,1
----------------
Please, add comments for these two lines.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-dwo.s:38-40
+	.asciz	"DWARF_VERSION 5"       # string offset=49
+.Linfo_string1:
+	.asciz	"DWARF_VERSION"         # string offset=65
----------------
The comments are misleading.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-dwo.s:41
+	.asciz	"DWARF_VERSION"         # string offset=65
+	.section	.debug_str_offsets.dwo,"e", at progbits
+.Lcu_str_off_start0:
----------------
Please, avoid splitting definitions of sections.

Add an empty line before the `.section` directives.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78500/new/

https://reviews.llvm.org/D78500