[PATCH] D78866: [DWARF5] Added support for emission of debug_macro.dwo section

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1299
+              TLOF.getDwarfMacroDWOSection()->getBeginSymbol());
+       else 
           U.addSectionLabel(U.getUnitDie(), dwarf::DW_AT_macros,
----------------
Remove the trailing whitespace.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:3006
 void DwarfDebug::emitDebugMacinfoDWO() {
-  // FIXME: Add support for macro.dwo section.
-  if (getDwarfVersion() >= 5)
-    return;
-  emitDebugMacinfoImpl(Asm->getObjFileLowering().getDwarfMacinfoDWOSection());
+  emitDebugMacinfoImpl(
+      getDwarfVersion() >= 5
----------------
The code should be similar to `emitDebugMacinfo()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78866/new/

https://reviews.llvm.org/D78866