[llvm] 163bd9d - Fix `-Wpedantic` warnings. NFC.

[David Blaikie via llvm-commits]

Not sure about everyone else, but I find it more informative to describe
what's actually being changed in the commit message, eg:

"Remove unnecessary semicolons

Found by -Wpedantic"

That way at a glance (just at the subject line) you know what the change is
doing. "Fix -Wpedantic warnings" doesn't really provide that much
information about what's being done.

On Tue, Apr 21, 2020 at 1:09 PM Michael Liao via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Michael Liao
> Date: 2020-04-21T16:09:17-04:00
> New Revision: 163bd9d858008c6f48ec38f3ba857faf9bd6c543
>
> URL:
> https://github.com/llvm/llvm-project/commit/163bd9d858008c6f48ec38f3ba857faf9bd6c543
> DIFF:
> https://github.com/llvm/llvm-project/commit/163bd9d858008c6f48ec38f3ba857faf9bd6c543.diff
>
> LOG: Fix `-Wpedantic` warnings. NFC.
>
> Added:
>
>
> Modified:
>     llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp
> b/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp
> index 2655ef304787..32f37c6d04cf 100644
> --- a/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp
> +++ b/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp
> @@ -319,7 +319,7 @@ LLVM_NODISCARD Value *Negator::visit(Value *V,
> unsigned Depth) {
>    }
>
>    llvm_unreachable("Can't get here. We always return from switch.");
> -};
> +}
>
>  LLVM_NODISCARD Optional<Negator::Result> Negator::run(Value *Root) {
>    Value *Negated = visit(Root, /*Depth=*/0);
> @@ -331,7 +331,7 @@ LLVM_NODISCARD Optional<Negator::Result>
> Negator::run(Value *Root) {
>      return llvm::None;
>    }
>    return std::make_pair(ArrayRef<Instruction *>(NewInstructions),
> Negated);
> -};
> +}
>
>  LLVM_NODISCARD Value *Negator::Negate(bool LHSIsZero, Value *Root,
>                                        InstCombiner &IC) {
> @@ -374,4 +374,4 @@ LLVM_NODISCARD Value *Negator::Negate(bool LHSIsZero,
> Value *Root,
>
>    // And return the new root.
>    return Res->second;
> -};
> +}
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200427/a67aa98b/attachment.html>