<div dir="ltr">Not sure about everyone else, but I find it more informative to describe what's actually being changed in the commit message, eg:<br><br>"Remove unnecessary semicolons<br><br>Found by -Wpedantic"<br><br>That way at a glance (just at the subject line) you know what the change is doing. "Fix -Wpedantic warnings" doesn't really provide that much information about what's being done.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 21, 2020 at 1:09 PM Michael Liao via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Michael Liao<br>
Date: 2020-04-21T16:09:17-04:00<br>
New Revision: 163bd9d858008c6f48ec38f3ba857faf9bd6c543<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/163bd9d858008c6f48ec38f3ba857faf9bd6c543" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/163bd9d858008c6f48ec38f3ba857faf9bd6c543</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/163bd9d858008c6f48ec38f3ba857faf9bd6c543.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/163bd9d858008c6f48ec38f3ba857faf9bd6c543.diff</a><br>
<br>
LOG: Fix `-Wpedantic` warnings. NFC.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp b/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp<br>
index 2655ef304787..32f37c6d04cf 100644<br>
--- a/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp<br>
+++ b/llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp<br>
@@ -319,7 +319,7 @@ LLVM_NODISCARD Value *Negator::visit(Value *V, unsigned Depth) {<br>
   }<br>
<br>
   llvm_unreachable("Can't get here. We always return from switch.");<br>
-};<br>
+}<br>
<br>
 LLVM_NODISCARD Optional<Negator::Result> Negator::run(Value *Root) {<br>
   Value *Negated = visit(Root, /*Depth=*/0);<br>
@@ -331,7 +331,7 @@ LLVM_NODISCARD Optional<Negator::Result> Negator::run(Value *Root) {<br>
     return llvm::None;<br>
   }<br>
   return std::make_pair(ArrayRef<Instruction *>(NewInstructions), Negated);<br>
-};<br>
+}<br>
<br>
 LLVM_NODISCARD Value *Negator::Negate(bool LHSIsZero, Value *Root,<br>
                                       InstCombiner &IC) {<br>
@@ -374,4 +374,4 @@ LLVM_NODISCARD Value *Negator::Negate(bool LHSIsZero, Value *Root,<br>
<br>
   // And return the new root.<br>
   return Res->second;<br>
-};<br>
+}<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>