[PATCH] D78888: [llvm-objcopy][MachO] Fix symbol table

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 14:34:15 PDT 2020


smeenai added a comment.

LGTM from the Mach-O side.



================
Comment at: llvm/tools/llvm-objcopy/MachO/Object.h:112
+
+  bool isExternalSymbol() const { return !isSTAB() && n_type & MachO::N_EXT; }
 
----------------
Why do we need the special case for STAB symbols?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78888/new/

https://reviews.llvm.org/D78888





More information about the llvm-commits mailing list