[PATCH] D78888: [llvm-objcopy][MachO] Fix symbol table

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 01:01:42 PDT 2020


jhenderson added a comment.

I don't know how viable this is, but it might be easier to understand the test if you name the symbols according to their interesting properties, e.g. "stab", "external", "external_stab" etc. That'll mean it'll be obvious reading the test output which tests have which properties.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/symbol-table.test:1
+## This test is based on a trimed down version of the binary built as follows:
+## a.c:
----------------
trimed -> trimmed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78888/new/

https://reviews.llvm.org/D78888





More information about the llvm-commits mailing list