[PATCH] D78959: [WIP][FileCollector] move Root creation

Jan Korous via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 14:01:18 PDT 2020


jkorous added a comment.

In D78959#2006231 <https://reviews.llvm.org/D78959#2006231>, @JDevlieghere wrote:

> For lldb for example it would be disappointing to reproduce a bug with reproducer capture enabled, only to find out at the last minute that we couldn't capture the files because we couldn't create the root.


Yes, this was the only reason I thought we might want to create it eagerly. Maybe we should then make existence of the dir (and maybe write access) an explicit requirement in doc comment and push this responsibility to client code? WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78959/new/

https://reviews.llvm.org/D78959





More information about the llvm-commits mailing list