[PATCH] D78959: [WIP][FileCollector] move Root creation

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

This seems reasonable. Another alternative might be taking the `error_code` as an output argument if we want to be eager in creating the root directory. However, I think this is a better solution.

I probably added it to the ctor thinking that you'd rather fail early rather than when something goes wrong. For lldb for example it would be disappointing to reproduce a bug with reproducer capture enabled, only to find out at the last minute that we couldn't capture the files because we couldn't create the root. However, I don't think that's something we should optimize for. The reproducers will already create the reproducer root directory, and it seems unlikely that this would succeed, but then creating a subdirectory (the FileCollector root) would fail.

LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78959/new/

https://reviews.llvm.org/D78959