[PATCH] D78875: [mlir] Optimize operand storage such that all operations can have resizable operand lists

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/IR/OperationSupport.cpp:134
+      std::make_move_iterator(inlineOperands.begin()),
+      std::make_move_iterator(inlineOperands.end()));
+
----------------
mehdi_amini wrote:
> Using a `std::vector` adds an extra indirection, you didn't think it was worth having a vector with inlined storage?
I think it would be worth it, but I don't have an idea of a size that would be good to use in general. I'm deferring that until I can get a few benchmarks that can give me a good indicator here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78875/new/

https://reviews.llvm.org/D78875