[PATCH] D78875: [mlir] Optimize operand storage such that all operations can have resizable operand lists
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 26 12:44:49 PDT 2020
mehdi_amini added inline comments.
================
Comment at: mlir/lib/IR/OperationSupport.cpp:134
+ std::make_move_iterator(inlineOperands.begin()),
+ std::make_move_iterator(inlineOperands.end()));
+
----------------
Using a `std::vector` adds an extra indirection, you didn't think it was worth having a vector with inlined storage?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78875/new/
https://reviews.llvm.org/D78875
More information about the llvm-commits
mailing list