[PATCH] D78773: Adjust libMLIR building to more closely follow libClang

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer accepted this revision.
stephenneuendorffer added a comment.
This revision is now accepted and ready to land.

I think this is at least a step in the right direction.

It looks like the make problems may be more fundamental.  CMake generates recursive makefiles, but these somewhat implicitly assume that hierarchical directories are processed in order (e.g. mlir/include before mlir/lib)   It seems that there is a somewhat fundamental problem with the current organization because mlir-linalg-ods-gen depends on MLIRAnalysis and MLIRParser, but these also depend on the dialects., but the linalg dialect depends on MLIRAnalysis to get the verifier.  There currently a 'hack' for mlir-tblgen which builds it independently of the other tools, but it's relatively dependence-free so that works easily.  To get mlir-linalg-ods-gen to work we'd need to do something similar for:

lib/Analysis/Verifier.cpp
lib/IR
lib/Parser

Even fixing mlir-headers so that all tablegen runs happen first doesn't work with makefiles because of the above subdirectory ordering problem .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78773/new/

https://reviews.llvm.org/D78773