[PATCH] D78773: Adjust libMLIR building to more closely follow libClang

[Valentin Churavy via Phabricator via llvm-commits]

vchuravy marked an inline comment as done.
vchuravy added a comment.

> Does this get us closer to fixing LLVM_LINK_LLVM_DYLIB?

Haven't tried yet, but I think it is a step in the right direction. I think

  target_link_libraries(${name} INTERFACE ${LLVM_COMMON_LIBS})

is necessary for that



================
Comment at: mlir/cmake/modules/MLIRConfig.cmake.in:22
 # Provide all our library targets to users.
-if(EXISTS @MLIR_CONFIG_EXPORTS_FILE@)
-  include("@MLIR_CONFIG_EXPORTS_FILE@")
----------------
stephenneuendorffer wrote:
> This was solving a specific problem.  Are you removing it because you believe that the problem is now solved a different way?
Yes we were never creating a `MLIR_CONFIG_EXPORTS_FILE`. With the changes to `add_mlir_library` we are now actually creating the file and are no longer polluting the `LLVM_CONFIG_EXPORTS_FILE`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78773/new/

https://reviews.llvm.org/D78773