[PATCH] D78786: [llvm-objcopy] Delete dead code after D71035. NFC

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 01:34:27 PDT 2020


grimar added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.cpp:2233
   // virtual addresses for all.
-  if (all_of(OrderedSegments,
-             [](const Segment *Seg) { return Seg->PAddr == 0; }))
-    for (Segment *Seg : OrderedSegments)
+  if (all_of(Segments, [](const Segment *Seg) { return Seg->PAddr == 0; }))
+    for (Segment *Seg : Segments)
----------------
`all_of` -> `llvm::all_of`
(it is consistent with how LLVM uses algorithms and makes it clear that we use llvm version of a algorithm).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78786/new/

https://reviews.llvm.org/D78786





More information about the llvm-commits mailing list