[PATCH] D78786: [llvm-objcopy] Delete dead code after D71035. NFC

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 00:29:44 PDT 2020


jhenderson added a comment.

IIRC from what I looked at yesterday, the segments aren't actually used for anything in binary output now, except in the calculation for `MinAddr` and `SecAddr`. Assuming that's correct (please check if you're going to do this!), does that mean we could simplify to looping over all Segments in the code you're modifying rather than just those which are ParentSegment instances?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78786/new/

https://reviews.llvm.org/D78786





More information about the llvm-commits mailing list