[PATCH] D78695: [llvm-objdump][ELF][NFC] Create ELFDump.h

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked 3 inline comments as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/tools/llvm-objdump/ELFDump.h:12
+
+#include "llvm/ADT/SmallVector.h"
+
----------------
MaskRay wrote:
> RKSimon wrote:
> > you can avoid the smallvector include as well:
> > template <typename T> class SmallVectorImpl;
> I think leaving this include here is fine. SmallVector.h is just so ubiquitous. 
I'm inclined to agree with @MaskRay, we'd need a header inclusion for `uint64_t` if we were not to include `SmallVector.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78695/new/

https://reviews.llvm.org/D78695