[PATCH] D78695: [llvm-objdump][ELF][NFC] Create ELFDump.h
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 23 10:48:17 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-objdump/ELFDump.h:12
+
+#include "llvm/ADT/SmallVector.h"
+
----------------
RKSimon wrote:
> you can avoid the smallvector include as well:
> template <typename T> class SmallVectorImpl;
I think leaving this include here is fine. SmallVector.h is just so ubiquitous.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78695/new/
https://reviews.llvm.org/D78695
More information about the llvm-commits
mailing list