[PATCH] D78771: Add dependency edges between generated headers and users

Thu Apr 23 16:52:54 PDT 2020

vchuravy marked an inline comment as done.
vchuravy added inline comments.

================
Comment at: mlir/lib/Analysis/CMakeLists.txt:24
+  DEPENDS
+  MLIRCallInterfacesIncGen
+  MLIRLoopLikeInterfaceIncGen
----------------
rriddle wrote:
> This seems really annoying if necessary. There is already an explicit library for the dependency, e.g. MLIRCallInterfaces, this seems redundant and exposes things that shouldn't necessarily need to be exposed.
Yeah it is really annoying... 

I had to add these for https://reviews.llvm.org/D78773 so it my be an issue with that PR.

To reproduce on D78773, this should be enough
```
cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=host -DLLVM_ENABLE_PROJECTS=mlir -DLLVM_BUILD_LLVM_DYLIB:BOOL=ON ../llvm
ninja
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78771/new/

https://reviews.llvm.org/D78771