[PATCH] D78771: Add dependency edges between generated headers and users

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 16:52:37 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Analysis/CMakeLists.txt:24
+  DEPENDS
+  MLIRCallInterfacesIncGen
+  MLIRLoopLikeInterfaceIncGen
----------------
This seems really annoying if necessary. There is already an explicit library for the dependency, e.g. MLIRCallInterfaces, this seems redundant and exposes things that shouldn't necessarily need to be exposed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78771/new/

https://reviews.llvm.org/D78771





More information about the llvm-commits mailing list