[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked 2 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h:12
 
+#include "llvm//DebugInfo/DWARF/DWARFUnit.h"
 #include "llvm/ADT/SmallVector.h"
----------------
probinson wrote:
> Typo `//`, also please keep includes in correct alphabetical order.
Ah, Sorry! I'll keep this in mind now onwards.
Thank You for this!


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:92
+    Optional<DWARFDataExtractor> StringOffsetsExtractor,
+    Optional<DataExtractor> StringExtractor, DWARFDataExtractor Data,
+    bool IsMacro) {
----------------
probinson wrote:
> It looks like StringExtractor should not be Optional?
I marked it optional since, for cases of `debug_macinfo[.dwo]` . String Extractor is not needed since the macro info are represented in macinfo[.dwo] section itself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736