[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h:12
 
+#include "llvm//DebugInfo/DWARF/DWARFUnit.h"
 #include "llvm/ADT/SmallVector.h"
----------------
Typo `//`, also please keep includes in correct alphabetical order.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:92
+    Optional<DWARFDataExtractor> StringOffsetsExtractor,
+    Optional<DataExtractor> StringExtractor, DWARFDataExtractor Data,
+    bool IsMacro) {
----------------
It looks like StringExtractor should not be Optional?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736