[PATCH] D78663: [builtins] Add 32-bit shift builtins

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 10:48:21 PDT 2020


MaskRay added inline comments.


================
Comment at: compiler-rt/test/builtins/Unit/ashlsi3_test.c:3
+// REQUIRES: librt_has_ashlsi3
+//===-- ashlsi3_test.c - Test __ashlsi3 -----------------------------------===//
+//
----------------
Test files don't need file headers. There are plenty of examples in `clang/test/`


================
Comment at: compiler-rt/test/builtins/Unit/ashrsi3_test.c:3
+// REQUIRES: librt_has_ashrsi3
+//===-- ashrsi3_test.c - Test __ashrsi3 -----------------------------------===//
+//
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78663/new/

https://reviews.llvm.org/D78663





More information about the llvm-commits mailing list