[PATCH] D78663: [builtins] Add 32-bit shift builtins

[Ayke via Phabricator via llvm-commits]

aykevl updated this revision to Diff 259616.
aykevl added a comment.

- formatted test files with clang-format
- moved shift implementations into common _impl.inc files
- fixed comment style of shift implementations (`//` instead of `/* ... */`)

I believe that addresses all review comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78663/new/

https://reviews.llvm.org/D78663

Files:
  compiler-rt/lib/builtins/CMakeLists.txt
  compiler-rt/lib/builtins/ashldi3.c
  compiler-rt/lib/builtins/ashlsi3.c
  compiler-rt/lib/builtins/ashlti3.c
  compiler-rt/lib/builtins/ashrdi3.c
  compiler-rt/lib/builtins/ashrsi3.c
  compiler-rt/lib/builtins/ashrti3.c
  compiler-rt/lib/builtins/int_ashl_impl.inc
  compiler-rt/lib/builtins/int_ashr_impl.inc
  compiler-rt/lib/builtins/int_lshr_impl.inc
  compiler-rt/lib/builtins/int_types.h
  compiler-rt/lib/builtins/lshrdi3.c
  compiler-rt/lib/builtins/lshrsi3.c
  compiler-rt/lib/builtins/lshrti3.c
  compiler-rt/test/builtins/Unit/ashlsi3_test.c
  compiler-rt/test/builtins/Unit/ashrsi3_test.c
  compiler-rt/test/builtins/Unit/lshrsi3_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78663.259616.patch
Type: text/x-patch
Size: 23820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200423/dd124fef/attachment.bin>