[PATCH] D78512: [llvm] Factor out inlining pipeline as a module pipeline.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked 2 inline comments as done.
mtrofin added a comment.

In D78512#1997571 <https://reviews.llvm.org/D78512#1997571>, @tejohnson wrote:

> Just a couple of suggestions for comment clarifications in the new test. I see that @jdoerfert asked whether this should be done for the old PM too. Would that make sense?


I can't seem to find @jdoerfert's question about the old PM - I only see the comment about NFC. Sorry if I missed it (am I not using phabricator correctly?)

To answer the question, the tests in the ML work outlined in D77752 <https://reviews.llvm.org/D77752> would be the main intended consumer. That work was only tailored to the new pass manager. It's a fair point to talk about whether to port that to the legacy PM, and what would testing look like there, but I think it's premature to do so at this point.

If a different scenario arises requiring a similar factoring, we can always add the code then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78512/new/

https://reviews.llvm.org/D78512