[PATCH] D78512: [llvm] Factor out inlining pipeline as a module pipeline.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Just a couple of suggestions for comment clarifications in the new test. I see that @jdoerfert asked whether this should be done for the old PM too. Would that make sense?



================
Comment at: llvm/test/Transforms/Inline/module-inlining.ll:1
+; modify_value will be inlined into main. At most, some trivial DCE would happen,
+; which in this case doesn't modify post-inlined main much.
----------------
"At most with just the inliner pass"?


================
Comment at: llvm/test/Transforms/Inline/module-inlining.ll:3
+; which in this case doesn't modify post-inlined main much.
+; In contrast, at the end of inlining (incl. function cleanups ran after inlining),
+; main will be reduced to a 'ret 10'
----------------
"In contrast, with the full set of module inliner related passes, ..."?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78512/new/

https://reviews.llvm.org/D78512