[PATCH] D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D74755#1998620 <https://reviews.llvm.org/D74755#1998620>, @jhenderson wrote:

> `sectionPhysicalAddr` (used in various places `IHexSectionWriter[Base]`).


Related to the previous point, but in the event that no section is found to have a PT_LOAD parent segment, then the behaviour is to fall back to using section virtual addresses rather than the physical addresses. This means that if all sections happen to be covered by an additional program header (admittedly relatively unlikely in normal usage, but certainly not impossible), the physical addresses will be ignored, and different address values will be emitted. This seems wrong to me, although I don't know how ihex is used in practice and therefore whether it matters that much. Still, given the previous point, I think it is important that we maintain the existing flattening algorithm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74755/new/

https://reviews.llvm.org/D74755