[PATCH] D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D74755#1998620 <https://reviews.llvm.org/D74755#1998620>, @jhenderson wrote:

> `IHexWriter::finalize::IsInPtLoad` (used to identify how to write things).


This one is a problem. Because the parent segment is no longer the most parental, this means that any segment nested in another segment (e.g. PT_GNU_RELRO, PT_TLS etc) will be omitted from the IHex output. I couldn't find any testing for this case, but if there were, it would fail - I experimented with adding an additional segment to ihex-elf-segments.yaml containing one of the sections, and the ihex-writer.test started failing with this change (but not without it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74755/new/

https://reviews.llvm.org/D74755