[PATCH] D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D74755#1998620 <https://reviews.llvm.org/D74755#1998620>, @jhenderson wrote:

> `BinaryWriter::finalize` used to calculate addresses of sections.


Analysis for this bit: assuming that segment addresses make sense (i.e. the address of a nested segment is the same relative distance to the top-level parent's address as the offsets are), this is not an issue, as the calculation `Sec.Offset - Sec.ParentSegment->Offset + Sec.ParentSegment->PAddr` should evaluate to the same regardless of which segment in the stack is picked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74755/new/

https://reviews.llvm.org/D74755