[PATCH] D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 01:34:21 PDT 2020


jhenderson added a comment.

Note for self: only places that still need to be checked where different Sec->ParentSegment value might have an impact are:

1. `sectionPhysicalAddr` (used in various places `IHexSectionWriter[Base]`).
2. `IHexWriter::finalize::IsInPtLoad` (used to identify how to write things).
3. `BinaryWriter::finalize` used to populate list of segments for ordering.
4. `BinaryWriter::finalize` used to calculate addresses of sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74755/new/

https://reviews.llvm.org/D74755





More information about the llvm-commits mailing list