[PATCH] D78602: [llvm-objcopy][MachO] Copy LC_LOAD_WEAK_DYLIB load commands

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/lc-weak-dylib.test.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy %t %t.copy
----------------
MaskRay wrote:
> alexshap wrote:
> > MaskRay wrote:
> > > Should the file be
> > > 
> > > lc-weak-dylib.test
> > > 
> > > or
> > > 
> > > lc-load-weak-dylib.test
> > > 
> > > ?
> > personally i think if we prefer dashes in such cases it should be lc-load-weak-dylib.test,
> > i don't mind renaming this test again, however, the above comment was suggesting the following: 
> > "perhaps lc-weak-dylib.test for this test".
> > I think  lc-load-weak-dylib.test is a better name.
> I meant, the test is named `*.test.test` now. Hope this is not intentional.
@MaskRay this might be a bug of Phabricator, it might be confused by "continuous file renaming", though i don't know. For me the latest revision (I've not uploaded anything new) looks like this: 
{F11781222}
(and of course the file name is correct)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78602/new/

https://reviews.llvm.org/D78602