[PATCH] D78602: [llvm-objcopy][MachO] Copy LC_LOAD_WEAK_DYLIB load commands

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

LG once the strange test file name `*.test.test` is fixed.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/lc-weak-dylib.test.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy %t %t.copy
----------------
alexshap wrote:
> MaskRay wrote:
> > Should the file be
> > 
> > lc-weak-dylib.test
> > 
> > or
> > 
> > lc-load-weak-dylib.test
> > 
> > ?
> personally i think if we prefer dashes in such cases it should be lc-load-weak-dylib.test,
> i don't mind renaming this test again, however, the above comment was suggesting the following: 
> "perhaps lc-weak-dylib.test for this test".
> I think  lc-load-weak-dylib.test is a better name.
I meant, the test is named `*.test.test` now. Hope this is not intentional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78602/new/

https://reviews.llvm.org/D78602