[PATCH] D78686: [PowerPC] Fix downcast from nullptr
Qing Shan Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 22 22:14:51 PDT 2020
steven.zhang added a comment.
Missing test. And PPCAIXAsmPrinter::emitEndOfAsmFile also has issues if it could be null. And it seems that, we miss this check also in:
./AsmParser/PPCAsmParser.cpp: getParser().getStreamer().getTargetStreamer());
./AsmParser/PPCAsmParser.cpp: getParser().getStreamer().getTargetStreamer());
./AsmParser/PPCAsmParser.cpp: getParser().getStreamer().getTargetStreamer());
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1416
if (isPPC64)
- TS.emitTCEntry(*TOCEntryTarget);
+ TS->emitTCEntry(*TOCEntryTarget);
else
----------------
null check ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78686/new/
https://reviews.llvm.org/D78686
More information about the llvm-commits
mailing list