[PATCH] D78686: [PowerPC] Fix downcast from nullptr

[Ng Zhi An via Phabricator via llvm-commits]

ngzhian created this revision.
Herald added subscribers: llvm-commits, shchenz, kbarton, hiraditya, nemanjai.
Herald added a project: LLVM.
ngzhian added a reviewer: nemanjai.
Herald added a subscriber: wuzish.
ngzhian added a subscriber: zbrid.

getTargetStreamer() might return null (e.g. when running
inlined-strings.ll test), downcasting to a reference will be wrong. This
is detectable with -fsanitize=null.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78686

Files:
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp


Index: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
+++ llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
@@ -1396,8 +1396,8 @@
 
   bool isPPC64 = DL.getPointerSizeInBits() == 64;
 
-  PPCTargetStreamer &TS =
-      static_cast<PPCTargetStreamer &>(*OutStreamer->getTargetStreamer());
+  PPCTargetStreamer *TS =
+      static_cast<PPCTargetStreamer *>(OutStreamer->getTargetStreamer());
 
   if (!TOC.empty()) {
     const char *Name = isPPC64 ? ".toc" : ".got2";
@@ -1413,7 +1413,7 @@
 
       OutStreamer->emitLabel(TOCEntryLabel);
       if (isPPC64)
-        TS.emitTCEntry(*TOCEntryTarget);
+        TS->emitTCEntry(*TOCEntryTarget);
       else
         OutStreamer->emitSymbolValue(TOCEntryTarget, 4);
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78686.259425.patch
Type: text/x-patch
Size: 820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200422/2f6714fd/attachment.bin>