[PATCH] D77601: Make SmallVector assert if it cannot grow.

[Andrew via Phabricator via llvm-commits]

browneee added a comment.

In D77601#1995831 <https://reviews.llvm.org/D77601#1995831>, @dexonsmith wrote:

> In D77601#1974745 <https://reviews.llvm.org/D77601#1974745>, @browneee wrote:
>
> > Incorporated into https://reviews.llvm.org/D77621  (because this is not submitted yet, and that change now moves this code).
>
>
> Based on this comment I thought you'd abandoned this patch...


I should have been more explicit here. After D77621 <https://reviews.llvm.org/D77621> was reverted, I picked it up again to make this change separately.

> 
> 
> In D77601#1995667 <https://reviews.llvm.org/D77601#1995667>, @browneee wrote:
> 
>> Rebase to head.
> 
> 
> But since you're updating here, I should note that the patch as it looks here is still working with `UINT32_MAX` instead of `max_size()`.  It should be updated in light of https://reviews.llvm.org/D77621.

Sorry, I didn't see this comment before pushing.

I think UINT32_MAX is consistent with existing usage in these functions. In D77621 <https://reviews.llvm.org/D77621> the max_size() part of the change was necessary because it could vary. Here we can leave that change to a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77601/new/

https://reviews.llvm.org/D77601