[PATCH] D78245: [LIT] Make `%T` unique for every test

Tue Apr 21 10:15:05 PDT 2020

ldionne added a comment.

In D78245#1986587 <https://reviews.llvm.org/D78245#1986587>, @ldionne wrote:

> In D78245#1985201 <https://reviews.llvm.org/D78245#1985201>, @thakis wrote:
>
> > Are you aware of https://llvm.org/docs/CommandGuide/lit.html#substitutions ("%T: parent directory of %t (not unique, deprecated, do not use)")? We've talked about this a bunch in the past, and the decision back then was to do `mkdir %t` in the tests that need a dir, and to remove %T over time.
>
>
> I was aware of it, and TBH I don't know why it's that way, but I've wished it would be different several times. Doing `mkdir %t` isn't an option for us, as all tests would need to do it. So we'd use the solution we used before this patch.
>
> @thakis  Could you link to previous discussions about `%T`? I'm sure there are reasons for the way things are today, but I'd like to understand them.

Gentle ping -- are there previous discussions on why `%T` was deprecated? I'm sure there is, but in the absence of any documentation supporting otherwise, it seems to be a useful feature.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78245/new/

https://reviews.llvm.org/D78245