[PATCH] D78128: Implement some functions in NativeSession.

[Michael Liao via Phabricator via llvm-commits]

hliao added a comment.

In D78128#1995209 <https://reviews.llvm.org/D78128#1995209>, @MaskRay wrote:

> http://45.33.8.238/linux/15836/step_12.txt
>
> After fixing the `-DLLVM_ENABLE_ABI_BREAKING_CHECKS=on` problem locally, the unittest (`unittests/DebugInfo/PDB/DebugInfoPDBTests`) still fails.
>
> (
>  An erroring `Expected` must be explicitly checked to avoid `-DLLVM_ENABLE_ABI_BREAKING_CHECKS=on` failures.
>
>   if (Expected<std::unique_ptr<PDBFile>> File = loadPdbFile(PdbPath, Allocator))
>     return std::string(PdbPath);
>   else
>     return File.takeError();
>   
>
> )


Even more, as the test reads the PDB file path from that EXE file (`llvm-project/llvm/unittests/DebugInfo/PDB/Inputs/SimpleTest.exe`), that path is an absolute path in Windows format (`C:\\src\\llvm-project\\llvm\\unittests\\DebugInfo\\PDB\\Inputs\\SimpleTest.pdb`). On Linux builds, that always fail and, on Windows, we are only luck if we have the same dir layout by chance. Could you fix that by taking relative path and disable that test on non-Windows platforms?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78128/new/

https://reviews.llvm.org/D78128