[PATCH] D78128: Implement some functions in NativeSession.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

http://45.33.8.238/linux/15836/step_12.txt

After fixing the `-DLLVM_ENABLE_ABI_BREAKING_CHECKS=on` problem locally, the unittest (`unittests/DebugInfo/PDB/DebugInfoPDBTests`) still fails.

(
An erroring `Expected` must be explicitly checked to avoid `-DLLVM_ENABLE_ABI_BREAKING_CHECKS=on` failures.

  if (Expected<std::unique_ptr<PDBFile>> File = loadPdbFile(PdbPath, Allocator))
    return std::string(PdbPath);
  else
    return File.takeError();

)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78128/new/

https://reviews.llvm.org/D78128