[PATCH] D78549: Improve disassembly of branch targets in non-relocatable objects

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 04:49:53 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1574
+
+            if(TargetSym != nullptr) {
               uint64_t TargetAddress = TargetSym->Addr;
----------------
grimar wrote:
> Missing a space after `if`. Perhaps 'if (TargetSym)' would be more consistent with the code in this file.
Thanks. Somehow I forgot to clang-format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78549/new/

https://reviews.llvm.org/D78549





More information about the llvm-commits mailing list